fix the warning torch_dtype is deprecated#12841
Merged
DN6 merged 5 commits intohuggingface:mainfrom Jan 9, 2026
Merged
Conversation
DN6
reviewed
Jan 2, 2026
|
|
||
| # For transformers models, use 'dtype' instead of 'torch_dtype' to avoid deprecation warnings | ||
| if issubclass(class_obj, torch.nn.Module): | ||
| if is_transformers_model: |
Collaborator
There was a problem hiding this comment.
Think we would also need to check if transformers version is greater than 4.56.0.
masioware
approved these changes
Jan 5, 2026
…fusers into feature/fix-warning-deprecated
Contributor
Author
|
@DN6 Thanks for the review! I've updated the code to check for transformers version >= 4.56.0 before using the |
DN6
approved these changes
Jan 6, 2026
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
@bot /style |
Contributor
Author
|
@DN6 Linting errors have been fixed. CI is waiting for workflow approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When users load pipelines like
QwenImageEditPipelinewith thetorch_dtypeparameter, they see a deprecation warning from the Transformers library. However, changing todtype(as the warning suggests) causes errors because diffusers'from_pretraineddoesn't acceptdtypeas a parameter.This creates a confusing user experience where:
Solution
This PR internally converts
torch_dtypetodtypewhen loading Transformers models (transformers >= 4.20.0), while keepingtorch_dtypefor diffusers models and other components.Fixes #12840
Who can review?